Re: [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() infake_signal_wake_up()

From: Oleg Nesterov
Date: Mon Aug 29 2011 - 12:40:22 EST


On 08/29, Tejun Heo wrote:
>
> --- work.orig/kernel/freezer.c
> +++ work/kernel/freezer.c
> @@ -103,9 +103,10 @@ static void fake_signal_wake_up(struct t
> {
> unsigned long flags;
>
> - spin_lock_irqsave(&p->sighand->siglock, flags);
> - signal_wake_up(p, 0);
> - spin_unlock_irqrestore(&p->sighand->siglock, flags);
> + if (lock_task_sighand(p, &flags)) {
> + signal_wake_up(p, 0);
> + unlock_task_sighand(p, &flags);
> + }

Yes, this looks correct.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/