Re: [PATCH v4 00/18] Introduce a led trigger for CPU activity andconsolidate LED driver in ARM

[Bryan Wu]

On Mon, Aug 29, 2011 at 11:13 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 29, 2011 at 09:18:29PM +0800, Bryan Wu wrote:
>> On Mon, Aug 29, 2011 at 7:00 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> > On Fri, Aug 26, 2011 at 11:03 AM, Bryan Wu <bryan.wu@xxxxxxxxxxxxx> wrote:
>> >
>> >> Based on Linus Walleij's ARM LED consolidation work, this patchset introduce a
>> >> new generic led trigger for CPU not only for ARM but also for others.
>> >
>> > I think Russell was pretty clear that he saw problems inside the "new LEDs"
>> > subsystem (drivers/leds) that need be fixed before we migrate this support
>> > to use the LED class devices.
>> >
>> > Can you see if you can address his comment on the earlier realview patch,
>> > i.e. this:
>> > http://marc.info/?l=linux-arm-kernel&m=131237280009775&w=2
>> >
>>
>> Yeah, I replied that email with a patch to select LEDS_CLASS when
>> CONFIG_NEW_LEDS=y.
>
> I don't see any point to that:
>

Actually, what I really want to propose is to kill this option and
build in leds-class.c when CONFIG_NEW_LEDS=y, since most of functions
of leds-class.c are widely used by others.

And you know, to select it as default is a simple workaround.

Thanks,
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/