Re: [PATCH v2] block: document blk-plug

[Andrew Morton]

On Mon, 29 Aug 2011 16:58:21 +0530
Suresh Jayaraman <sjayaraman@xxxxxxx> wrote:

> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -863,17 +863,23 @@ struct request_queue *blk_alloc_queue_node(gfp_t, int);
>  extern void blk_put_queue(struct request_queue *);
>  
>  /*
> + * blk_plug allows to build up a queue of related requests by holding the I/O
> + * fragments for a short period. This allows merging of sequential requests
> + * into single larger request. As the requests are moved from per-task list to
> + * the device's request_queue in a batch, this results in improved
> + * scalability as the lock contention for request_queue lock is reduced.
> + *
>   * Note: Code in between changing the blk_plug list/cb_list or element of such
>   * lists is preemptable, but such code can't do sleep (or be very careful),
>   * otherwise data is corrupted. For details, please check schedule() where
>   * blk_schedule_flush_plug() is called.

What does the older part of this comment mean?  If a code section is
preemptible then it *will* sleep.  That's what preemption does.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/