Re: [PATCH 18/24] sctp: Remove unnecessary OOM logging messages

From: David Miller
Date: Mon Aug 29 2011 - 18:15:42 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Mon, 29 Aug 2011 23:51:21 +0200

> Le lundi 29 août 2011 à 23:43 +0200, Eric Dumazet a écrit :
>
>> Furthermore, a failed vmalloc() is not guaranteed to emit an OOM
>> message, is it ?
>
> It currently displays a message without context :
>
> vmap allocation for size XXXXXX failed: use vmalloc=<size> to increase
> size.
>
> So we dont know which part of the kernel asked this allocation.
>
> Please dont remove existing error messages after failed vmalloc() calls.

Indeed.

Joe, these vmalloc() and also the __GFP_NOWARN cases will need to be
attended to and this series resubmitted as such.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/