Re: [PATCH v3 10/18] Staging: cx25821: Fix long lines incx25821-audio-upstream.c

From: Dan Carpenter
Date: Tue Aug 30 2011 - 10:15:20 EST


On Tue, Aug 30, 2011 at 12:17:05PM +0800, Leonid V. Fedorenchik wrote:
> @@ -603,7 +599,8 @@ static irqreturn_t cx25821_upstream_irq_audio(int irq, void *dev_id)
> if (!dev)
> return -1;
>
> - sram_ch = dev->channels[dev->_audio_upstream_channel_select].sram_channels;
> + sram_ch = dev->channels[dev->_audio_upstream_channel_select].
> + sram_channels;

$ echo -n "_audio_upstream_channel_select" | wc -c
30

I think I may have found the problem. (Don't use variable names that
are a 30 zillion chars long).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/