RE: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handlingin vmbus_bus_init()

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> Sent: Tuesday, August 30, 2011 10:07 AM
> To: Dan Carpenter
> Cc: KY Srinivasan; devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang; gregkh@xxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx
> Subject: Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in
> vmbus_bus_init()
> 
> On Tue, Aug 30, 2011 at 01:29:49PM +0300, Dan Carpenter wrote:
> > > err3:
> > > 	free_irq(irq, hv_acpi_dev);
> > > err2:
> > > 	bus_unregister(&hv_bus);
> > > err1:
> > > 	hv_cleanup();
> >
> > Also here is an oldbie trick.  You could use multiples of ten like
> > err30, err20, and err10.  That way if you can add more error handling
> > in the middle without changing the numbering.  I knew my GW-BASIC
> > experience would come in handy one day.  :)
> >
> > The better way to label things is based on what happens when you get
> > there: err_irq, err_unregister, err_cleanup.
> 
> Yes, that's the best way to do this, thanks for pointing it out.

I will fix this up.

Regards,

K. Y
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/