Re: [PATCH] All Arch: remove linkage for sys_nfsservctl system call

From: J. Bruce Fields
Date: Wed Aug 31 2011 - 09:47:11 EST


On Tue, Aug 30, 2011 at 09:11:50AM +1000, NeilBrown wrote:
> On Tue, 30 Aug 2011 08:57:52 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> wrote:
>
> > Hi Bruce,
> >
> > On Fri, 26 Aug 2011 18:03:11 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote:
> > >
> > > From: NeilBrown <neilb@xxxxxxx>
> > >
> > > The nfsservctl system call is now gone, so we should remove all
> > > linkage for it.
> > >
> > > Signed-off-by: NeilBrown <neilb@xxxxxxx>
> > > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
> > > ---
> > >
> > > I don't normally have to deal with this kind of cross-architecture
> > > patch; is this the right etiquette for it?
> >
> > It turns out (with hindsight) that my reaction to this patch should have
> > been:
> >
> > If you haven't built this on all architectures (an noone expects you to
> > actually do that), then it should spend a day or two in linux-next before
> > being sent to Linus.
> >
>
> Hi Stephen,
> Thanks for your help in sorting this out. I have no idea how I missed those
> few nfsservctl references but I clearly did and you and -next have proved
> valuable yet again.
>
> And really *everything* should spend a few days in linux-next before going
> to Linus. We all know that but it sometimes seem hard to *do* that ....
> until we have learnt the hard way a couple of times :-(

Yes, sorry, I'll know not to skip -next, next time....

(My excuse: I've been advertising to -next only stuff that I've done
with and committed, and this was something I wasn't even sure I should
take.

But I could have either mailed it out labelled as [RFC], or stuck it in
a throwaway branch to merge into my -next branch.)

Apologies again, and thanks for dealing with it so promptly.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/