Re: [patch v2 28/35] Hexagon: Add ioremap support

From: Arnd Bergmann
Date: Wed Aug 31 2011 - 10:53:44 EST


On Tuesday 30 August 2011, Richard Kuo wrote:
> Signed-off-by: Richard Kuo <rkuo@xxxxxxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

> + if (ioremap_page_range(addr, addr+size, phys_addr, prot)) {
> + vunmap((void *)addr);
> + return NULL;
> + }
> +
> + flush_cache_vmap(addr, addr+size);

I think that ioremap_page_range implies the flush_cache_vmap already,
so there is no reason to do it again.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/