Re: [PATCH] gpio: rewrite U300 GPIO to use gpiolib

[Linus Walleij]

On Tue, Sep 6, 2011 at 10:49 AM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:

>> +#include <linux/io.h>
>> +#include <mach/hardware.h>
>> +#include <asm/irq.h>
>> +#include <asm-generic/gpio.h>
>>
>> +/* Map these overrides to gpiolib functions, simply */
>> +#define gpio_get_value  __gpio_get_value
>> +#define gpio_set_value  __gpio_set_value
>> +#define gpio_cansleep   __gpio_cansleep
>> +#define gpio_to_irq     __gpio_to_irq
>>
>> +#endif
>
> This is how mach/gpio.h ends up looking - two things:
>
> 1. is there any reason for asm/irq.h and linux/io.h in there?

No.

> 2. asm/gpio.h already includes asm-generic/gpio.h and defines
>   the dispatchers for the trivial case.

Yep.

> So, I think this is how it should look:
>
> #ifndef __MACH_U300_GPIO_H
> #define __MACH_U300_GPIO_H
> #include <mach/hardware.h>
> #endif
>
> Or even just:
>
> /* empty */

It works fine when left empty, so respinning it like
that.

> if mach/hardware.h include is not required for ARCH_NR_GPIOS.

It'll survive with just the default number of GPIOs.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/