Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

From: Michael S. Tsirkin
Date: Mon Sep 19 2011 - 02:01:27 EST


On Mon, Sep 19, 2011 at 01:05:17PM +0930, Rusty Russell wrote:
> On Sat, 20 Aug 2011 23:00:44 +0300, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > On Fri, Aug 19, 2011 at 07:33:07PM +0300, Sasha Levin wrote:
> > > Maybe this is better solved by copying the way it was done in PCI itself
> > > with capability linked list?
> >
> > There are any number of ways to lay out the structure. I went for what
> > seemed a simplest one. For MSI-X the train has left the station. We
> > can probably still tweak where the high 32 bit features
> > for 64 bit features are. No idea if it's worth it.
>
> Sorry, this has been in the back of my mind. I think it's a good idea;
> can we use the capability linked list for pre-device specific stuff from
> now on?
>
> Thanks,
> Rusty.

Do we even want capability bits then?
We can give each capability an ack flag ...

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/