Re: [PATCH] mmc : Use wait_for_completion_timeout() instead ofwait_for_completion in case of write.

[Murali Krishna Palnati]

On Tue, Sep 20, 2011 at 7:52 PM, NamJae Jeon <linkinjeon@xxxxxxxxx> wrote:
> It may be no good choice that sw timer is on host driver. also I don't
> know what is different.

It helps to have this functionality implemented at host controller
layer so that the host layer is informed about this. If we just end
the request from the MMC core layer, host controller driver doesnt
even kow about that and it remains in the same state processing the
request (that already got timed out at core layer). It is good to have
the host layer trigger this timeout, do necessary clean up and then
duly end the request by informing the core layer by calling
mmc_request_done().

Let me put the question in this way. If the core layer times out
(because of wait_for_completion_timeout) then in the patch that you
have submitted, i dont see how the host layer knows about it.
Apologize, if i sound like a broken record saying the same thing again
and again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/