Re: Re: Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains

[Péter Ujfalusi]

On Wednesday 21 September 2011 13:39:31 Mark Brown wrote:
> The key problem here is that you sent a change saying "change the
> default volume" with no other context in either the changelog or the
> code.  If you've got code that's actively managing the volume register
> while presenting a nice view to the application layer so that the
> register value isn't directly seen in the way it is for standard ASoC
> controls that's a very different thing to standard code.  I'm not going
> to remember the details of everything in every CODEC driver.
> 
> > We do have other scenarios covered, but this initialization was missing.
> > This resulted that the _first_ playback has pop noise, but all
> > subsequent playbacks were fine, since we had the runtime fix for this.
> 
> So what you're doing here is really a bug fix for the ramping code.

I will update the commit message, and I'll also put a comment to the code to 
explain it clearly.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/