Re: [patch] agp: potential info leak in compat_agpioc_info_wrap()

[Dan Carpenter]

On Fri, Sep 23, 2011 at 09:04:15AM +0200, Eric Dumazet wrote:
> > The agp_info32 struct has a 4 byte hole in it so we need to clear
> > that before copying it to userspace.
> > 
> > struct agp_info32 {
> >         struct agp_version         version;              /*     0     0 */
> > 
> >         /* XXX 4 bytes hole, try to pack */
> > 
> 
> This makes no sense :
> 
> Why should we have a 32bit hole before an u32 field ?
> 

Crap.  You're right.  It saw the agp_version struct as a hole.

Sorry for the noise.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/