Re: [PATCH 09/10] drbd: Remove volume numbers from struct p_header95

[Kyle Moffett]

Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@xxxxxxxxxx> wrote:
> From: Andreas Gruenbacher <agruen@xxxxxxxxxx>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
> ---
[...snip...]
> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
> index 3310986..99b467e 100644
> --- a/drivers/block/drbd/drbd_main.c
> +++ b/drivers/block/drbd/drbd_main.c
> @@ -717,11 +717,11 @@ static unsigned int prepare_header80(struct p_header80 *h, enum drbd_packet cmd,
> Â Â Â Âreturn sizeof(struct p_header80);
> Â}
>
> -static unsigned int prepare_header95(struct p_header95 *h, enum drbd_packet cmd, int size, int vnr)
> +static unsigned int prepare_header95(struct p_header95 *h, enum drbd_packet cmd, int size)
> Â{
>    Âh->magic  = cpu_to_be16(DRBD_MAGIC_BIG);
> Â Â Â Âh->command = cpu_to_be16(cmd);
> - Â Â Â h->vol_n_len = cpu_to_be32(vnr << 24 | size);
> + Â Â Â h->length = cpu_to_be32(size);
> Â Â Â Âreturn sizeof(struct p_header95);
> Â}

This patch needs a commit message indicating why it does not break
compatibility.  If you are guaranteed that the "vnr" passed into
prepare_header95 is always zero, then you should indicate why that is
true.

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/