Re: [PATCH 04/10] drbd: Replace and remove old primitives

[Kyle Moffett]

Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@xxxxxxxxxx> wrote:
> From: Andreas Gruenbacher <agruen@xxxxxxxxxx>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
> ---
> Âdrivers/block/drbd/drbd_int.h   Â|  45 +----
> Âdrivers/block/drbd/drbd_main.c   | Â502 ++++++++++++++++--------------------
> Âdrivers/block/drbd/drbd_receiver.c | Â 86 ++++---
> Âdrivers/block/drbd/drbd_worker.c  |  24 +-
> Â4 files changed, 294 insertions(+), 363 deletions(-)

I'm afraid this commit is waaaaay too large and complicated
to have a one-line commit message.

You should either split this up into more pieces or you should
write a detailed log indicated what this is supposed to be doing
and why it is OK.  (Or both).

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/