Re: [PATCH 1/1] vmscan.c: Invalid strict_strtoul check inwrite_scan_unevictable_node

[KAMEZAWA Hiroyuki]

On Sun, 25 Sep 2011 16:29:40 +0530
Kautuk Consul <consul.kautuk@xxxxxxxxx> wrote:

> write_scan_unavictable_node checks the value req returned by
> strict_strtoul and returns 1 if req is 0.
> 
> However, when strict_strtoul returns 0, it means successful conversion
> of buf to unsigned long.
> 
> Due to this, the function was not proceeding to scan the zones for
> unevictable pages even though we write a valid value to the 
> scan_unevictable_pages sys file.
> 
> Changing this if check slightly to check for invalid value 
> in buf as well as 0 value stored in res after successful conversion
> via strict_strtoul.
> In both cases, we do not perform the scanning of this node's zones.
> 
> Signed-off-by: Kautuk Consul <consul.kautuk@xxxxxxxxx>

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/