Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half

[Bob Liu]

On Tue, Sep 27, 2011 at 5:13 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote:
>> local_bh_en/disable() has already deal with en/disable preempt, so rm the
>> dumplicated one from spinlock_api_up/smp.h head file.
>
> I bet you haven't tried booting this.. Âyou just broke stuff like:
>

I only tried it on blackfin arch and can boot successfully
although it's a simple single-cpu ystem.

> Âspin_lock_bh(&foo);
> Â/* do crap */
> Âspin_unlock(&foo);
> Â/* do some other crap */
> Âlocal_bh_enable();
>
>
> And yes that does happen.

Could you please give an example?  I did a simple search but no result.
I thought the user should use spin_lock_bh()/spin_unlock_bh() in pairs.

-- 
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/