Re: [PATCH] nfs-utils: mount: really return from errno test

[Hamo]

CC: Chuck Lever <chuck.lever@xxxxxxxxxx>

On Tue, Oct 11, 2011 at 5:44 PM, Hamo <hamo.by@xxxxxxxxx> wrote:
> We should only try next address family if we meet ECONNREFUSED or EHOSTUNREACH
> for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2.
> Before, only a break in swich can not make the program out of for loop.
>
> Signed-off-by: Yang Bai <hamo.by@xxxxxxxxx>
> ---
> Âutils/mount/stropts.c | Â Â6 ++++--
> Â1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 314a806..4032bf3 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -665,9 +665,10 @@ static int nfs_try_mount_v3v2(struct nfsmount_info *mi)
> Â Â Â Â Â Â Â Âcase EHOSTUNREACH:
> Â Â Â Â Â Â Â Â Â Â Â Âcontinue;
> Â Â Â Â Â Â Â Âdefault:
> - Â Â Â Â Â Â Â Â Â Â Â break;
> + Â Â Â Â Â Â Â Â Â Â Â goto out;
> Â Â Â Â Â Â Â Â}
> Â Â Â Â}
> +out:
> Â Â Â Âreturn ret;
> Â}
>
> @@ -751,9 +752,10 @@ static int nfs_try_mount_v4(struct nfsmount_info *mi)
> Â Â Â Â Â Â Â Âcase EHOSTUNREACH:
> Â Â Â Â Â Â Â Â Â Â Â Âcontinue;
> Â Â Â Â Â Â Â Âdefault:
> - Â Â Â Â Â Â Â Â Â Â Â break;
> + Â Â Â Â Â Â Â Â Â Â Â goto out;
> Â Â Â Â Â Â Â Â}
> Â Â Â Â}
> +out:
> Â Â Â Âreturn ret;
> Â}
>
> --
> 1.7.1
>



-- 
  """
  Keep It Simple,Stupid.
  """

Chinese Name: çæ
Nick Name: Hamo
Homepage: http://hamobai.com/
GPG KEY ID: 0xA4691A33
Key fingerprint = 09D5 2D78 8E2B 0995 CF8EÂ 4331 33C4 3D24 A469 1A33
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/