Re: [PATCH 2/5 v14] arm: omap: usb: ehci and ohci hwmod structuresfor omap3

[Munegowda, Keshava]

On Fri, Oct 14, 2011 at 1:41 PM, Paul Walmsley <paul@xxxxxxxxx> wrote:
> Hi
>
> On Fri, 14 Oct 2011, Munegowda, Keshava wrote:
>
>> On Fri, Oct 14, 2011 at 6:33 AM, Paul Walmsley <paul@xxxxxxxxx> wrote:
>
>> >  static __initdata struct omap_hwmod *omap3xxx_hwmods[] = {
>> >        &omap3xxx_l3_main_hwmod,
>> >        &omap3xxx_l4_core_hwmod,
>> > @@ -3151,6 +3365,7 @@ static __initdata struct omap_hwmod *omap3xxx_hwmods[] = {
>> >        &omap3xxx_uart1_hwmod,
>> >        &omap3xxx_uart2_hwmod,
>> >        &omap3xxx_uart3_hwmod,
>> > +
>>
>> why you have removed  &omap3xxx_usb_host_hs_hwmod,
>> and       &omap3xxx_usb_tll_hs_hwmod.?
>
> I have removed them because, according to the OMAP3430 ES1.0 Revision A
> TRM (SWPU100A), the HS USBHOST subsystem is not present on OMAP3430 ES1.0.
> Therefore the HS USBHOST modules must not be marked as being common to all
> OMAP3xxx chips in the hwmod data.
>
> If you have information that indicates that it's present on OMAP3430
> ES1.0, please let me know ASAP.


Thanks , I got your point

regards
keshava





>>
>>
>> >        /* dss class */
>> >        &omap3xxx_dss_dispc_hwmod,
>> >        &omap3xxx_dss_dsi1_hwmod,
>> > @@ -3206,6 +3421,8 @@ static __initdata struct omap_hwmod *omap3430es1_hwmods[] = {
>> >  static __initdata struct omap_hwmod *omap3430es2plus_hwmods[] = {
>> >        &omap3xxx_dss_core_hwmod,
>> >        &omap3xxx_usbhsotg_hwmod,
>> > +       &omap3xxx_usb_host_hs_hwmod,
>> > +       &omap3xxx_usb_tll_hs_hwmod,
>> >        NULL
>> >  };
>> >
>> > @@ -3223,12 +3440,16 @@ static __initdata struct omap_hwmod *omap36xx_hwmods[] = {
>> >        &omap36xx_sr1_hwmod,
>> >        &omap36xx_sr2_hwmod,
>> >        &omap3xxx_usbhsotg_hwmod,
>> > +       &omap3xxx_usb_host_hs_hwmod,
>> > +       &omap3xxx_usb_tll_hs_hwmod,
>> >        NULL
>> >  };
>> >
>> >  static __initdata struct omap_hwmod *am35xx_hwmods[] = {
>> >        &omap3xxx_dss_core_hwmod, /* XXX ??? */
>> >        &am35xx_usbhsotg_hwmod,
>> > +       &omap3xxx_usb_host_hs_hwmod,
>> > +       &omap3xxx_usb_tll_hs_hwmod,
>> >        NULL
>> >  };
>> >
>> > --
>> > 1.7.7
>> >
>> >
>>
>
>
> - Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/