Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files(part 1)

[James Morris]

On Fri, 14 Oct 2011, Dmitry Kasatkin wrote:

> +MPI mpi_alloc(unsigned nlimbs)
> +{
> +	MPI a;
> +
> +	a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);

Generally, typedef structs are frowned upon in the kernel.  I'd prefer to 
see this (and any others) changed to a normal type.

Also, kmalloc return values do not need to be cast, they're void *.

> +EXPORT_SYMBOL(mpi_alloc);

New interfaces should be EXPORT_SYMBOL_GPL.


-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/