Re: [PATCH 02/10] block: fix genhd refcounting inblkio_policy_parse_and_set()

[Vivek Goyal]

On Wed, Oct 19, 2011 at 09:29:02AM -0700, Tejun Heo wrote:
> Hello,
> 
> On Wed, Oct 19, 2011 at 09:26:57AM -0400, Vivek Goyal wrote:
> > What's the advantage of collapsing blkio_check_dev_num(). Why not put the
> > reference to gendisk in this function before returning either success or
> > failure.
> 
> Heh, at first, I just thought there would be something which depends
> on disk still being around in the code path as unsynchronized one time
> check upfront doesn't really guarantee anything; then, I realized
> there was nothing, but I still left it like that because I personally
> think blkio_check_dev_num() w/o surrounding exclusion is a bad
> interface.  It's at best opportunistic and likely to mislead people
> into believing that there's some magical implied synchronization.
> 
> Also, I'm planning on cleaning up synchronization around iocg and for
> it to work properly, it'll be necessary to do proper ref counting and
> removal on release anyway.

Are you trying to tie the rules with actual presence of device. Current
model is that we just check for a valid device while somebody is
specifying the rule. After that device can go away and rule can still
be there.  We are just trying to make sure that when you are putting
the rule, atleast at that time device is present.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/