Re: [PATCH] gpiolib: Provide a definition of struct gpio for thestub gpiolib

From: Grant Likely
Date: Mon Oct 24 2011 - 08:01:25 EST


On Mon, Oct 24, 2011 at 01:27:29PM +0200, Mark Brown wrote:
> This makes the stub gpio_request_array() much more usable as drivers can
> declare struct gpio variables.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Shouldn't this patch remove the definition from
include/asm-generic/gpio.h at the same time?

g.

> ---
> include/linux/gpio.h | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/gpio.h b/include/linux/gpio.h
> index 17b5a0d..e885103 100644
> --- a/include/linux/gpio.h
> +++ b/include/linux/gpio.h
> @@ -24,7 +24,6 @@
> #include <linux/errno.h>
>
> struct device;
> -struct gpio;
> struct gpio_chip;
>
> /*
> @@ -36,6 +35,12 @@ struct gpio_chip;
> * warning when something is wrongly called.
> */
>
> +struct gpio {
> + unsigned gpio;
> + unsigned long flags;
> + const char *label;
> +};
> +
> static inline bool gpio_is_valid(int number)
> {
> return false;
> --
> 1.7.6.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/