Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data

[Rajendra Nayak]

On Monday 24 October 2011 07:17 PM, Shawn Guo wrote:
> On Mon, Oct 24, 2011 at 02:43:58PM +0530, Rajendra Nayak wrote:
> > Case 2:
> > One device for all regulators:
> >
> > DT nodes look something like this
> >
> > regulators {
> > 	reg1: reg@1 {
> > 			...
> > 			...
> > 	};
> >
> > 	reg2: reg@2 {
> > 			...
> > 			...
> > 	};
> > };
> >
> > The regulator driver probes only one device and the dev->of_node
> > points to the "regulators" node above.
>
> The mc13892 example I put in the reply to Grant demonstrates that
> for some case, dev->of_node is NULL (devices are created by mfd core).

In that case should you not be first converting the mfd driver to
register regulator devices using DT?
Thats what we did for OMAP, and hence we always have the of_node
populated when the regulator devices are probed.
See this patch from Benoit on how thats done for twl devices..
http://marc.info/?l=linux-omap&m=131489864814428&w=2

> > The regulator driver then based on compatible property extracts
> > and registers all the child nodes of "regulators" (for ex: reg1, reg2
> > above) with each call to regulator_register and passes the child nodes
> > as of_node to be associated with the regulator device.
> I still think the discovery of all the child nodes of "regulators" does
> not necessarily need to be done in regulator driver.  Instead, it can
> be done in regulator core.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/