Re: [PATCH 09/24] GFS2: Fix lseek after SEEK_DATA, SEEK_HOLE havebeen added

From: Andi Kleen
Date: Tue Oct 25 2011 - 03:54:47 EST


On Mon, Oct 24, 2011 at 01:48:23PM +0100, Steven Whitehouse wrote:
> We need to take the inode's glock whenever the inode's size
> is referenced, otherwise it might not be uptodate. Even
> though generic_file_llseek_unlocked() doesn't implement
> SEEK_DATA, SEEK_HOLE directly, it does reference the inode's
> size in those cases, so we need to add them to the list
> of origins which need the glock.
>
> Signed-off-by: Steven Whitehouse <swhiteho@xxxxxxxxxx>
> Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Looks good.

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/