Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules notbuilt in-tree

[Ben Hutchings]

On Tue, 2011-10-25 at 11:38 -0400, Nick Bowler wrote:
> On 2011-10-25 14:26 +1030, Rusty Russell wrote:
> > From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Subject: module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree
> > Date: Mon, 24 Oct 2011 15:12:28 +0200
> > 
> > Use of the GPL or a compatible licence doesn't necessarily make the code
> > any good.  We already consider staging modules to be suspect, and this
> > should also be true for out-of-tree modules which may receive very
> > little review.
> > 
> > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Reviewed-by: Dave Jones <davej@xxxxxxxxxx>
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (patched oops-tracing.txt)
> > ---
> >  Documentation/oops-tracing.txt |    2 ++
> >  include/linux/kernel.h         |    1 +
> >  kernel/module.c                |    5 +++++
> >  kernel/panic.c                 |    2 ++
> >  scripts/mod/modpost.c          |    7 +++++++
> >  5 files changed, 17 insertions(+)
> 
> This patch prevents the use of lockdep for debugging out of tree
> modules, which is rather mean.

It was already disabled for staging modules, which seems equally
unhelpful.  Maybe it should print taint flags at the top of its warnings
instead.

Ben.

-- 
Ben Hutchings
DNRC Motto:  I can please only one person per day.
Today is not your day.  Tomorrow isn't looking good either.

Attachment: signature.asc
Description: This is a digitally signed message part