Re: [PATCH] serial/8250_pci: add a quirk for the kt serial controller

[Greg KH]

On Tue, Oct 25, 2011 at 01:16:34PM -0700, Dan Williams wrote:
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> Date: Sun, 23 Oct 2011 15:06:24 -0700
> Subject: [PATCH v2] serial/8250_pci: add a quirk for the kt serial controller
> 
> Workaround dropped notifications in the iir register.  Prevent reads
> coincident with new interrupt notifications by reading the iir at most
> once per interrupt.
> 
> Reported-by: Nhan H Mai <nhan.h.mai@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Much better.

But.

Do you really think I can apply a patch that looks like this above?  I
have to edit the text of the email before I apply it.

Now I'm a bit grumpy about this at the moment as Linus yelled at me for
patches where I missed this on a few for the 3.2 merge window, so I'm
going to push back on people now very hard.

Please send this in a format that I can run 'git am' on the email you
send me.  I could not do that here, otherwise we would end up with a
duplicate header in the changelog message.

Yes, it makes you do a bit more work, but when you are handling
thousands of patches like me, you scale better than I do :)

Actually, it's just making you do it properly, along with everyone else,
which is a good thing, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/