Re: [PATCH] APICID: Avoid false sharing on the read mostlyx86_cpu_to_apicid

From: David Rientjes
Date: Wed Oct 26 2011 - 02:47:15 EST


On Wed, 26 Oct 2011, Eial Czerwacki wrote:

> >> Signed-off-by: Eial Czerwacki<eial@xxxxxxxxxxx>
> >> Signed-off-by: Shai Fultheim<shai@xxxxxxxxxxx>
> >> Author: Ravikiran Thirumalai<kiran@xxxxxxxxxxxx>
> >
> > If the author isn't you, then the patch should start with a single line
> > that says "From: name <email>" of the author followed by a blank line.
> > It's also strange that the author doesn't have a sign-off line.
> >
>
>
> the author is mentioned after the last sign-off.
>

That's not the way it's done, as I said, the patch needs to start with a
single line like this:

From: Ravikiran Thirumalai <kiran@xxxxxxxxxxxx>

...

and if that person signed it off, then it needs to appear as

Signed-off-by: ...

as the first one in the chain. Please see part 15 of section 1 of
Documentation/SubmittingPatches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/