Re: [PATCH v4] dmaengine: add CSR SiRFprimaII DMAC driver

[Vinod Koul]

On Mon, 2011-10-17 at 20:08 -0700, Barry Song wrote:
> From: Rongjun Ying <Rongjun.Ying@xxxxxxx>
> 
> Cc: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Rongjun Ying <rongjun.ying@xxxxxxx>
> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx>
> ---
>  -v4:
>  add error handler in probe;
>  free resource in remove;
>  add necessary comments in source codes;
>  fix the mismatch of license between file head and MODULE_LINCENSE;
>  define MACRO to replace magic number for xlen/dma_width boundary.
Barry,

You should _always_ run checkpatch before sending patches. It should
have 0 errors.

ERROR: trailing whitespace
#773: FILE: drivers/dma/sirf-dma.c:649:
+^I$


Also there are bunch of 80char warning, see if you can reduce/eliminate
them without sacrificing the code readability, and looking at them it
seems possible

Also, Please ensure you send patches which compile with ZERO warnings:
drivers/dma/sirf-dma.c: In function 'sirfsoc_dma_probe':
drivers/dma/sirf-dma.c:616: warning: assignment from incompatible pointer type
drivers/dma/sirf-dma.c:617: warning: assignment from incompatible pointer type
which comes from the fact that your prep_interleaved_dma does not have
last argument of flags.
On the second one you have not rebased to patch from Jassi which I
applied after converting direction stuff.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/