Re: [PATCH v4] dmaengine: add CSR SiRFprimaII DMAC driver

[Vinod Koul]

On Thu, 2011-10-27 at 09:33 +0100, Russell King - ARM Linux wrote:
> On Thu, Oct 27, 2011 at 01:48:55PM +0530, Vinod Koul wrote:
> > On Mon, 2011-10-17 at 20:08 -0700, Barry Song wrote:
> > > From: Rongjun Ying <Rongjun.Ying@xxxxxxx>
> > > 
> > > Cc: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> > > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > > Signed-off-by: Rongjun Ying <rongjun.ying@xxxxxxx>
> > > Signed-off-by: Barry Song <Baohua.Song@xxxxxxx>
> > > ---
> > >  -v4:
> > >  add error handler in probe;
> > >  free resource in remove;
> > >  add necessary comments in source codes;
> > >  fix the mismatch of license between file head and MODULE_LINCENSE;
> > >  define MACRO to replace magic number for xlen/dma_width boundary.
> > Barry,
> > 
> > You should _always_ run checkpatch before sending patches. It should
> > have 0 errors.
> 
> Not true. 
> 
> > ERROR: trailing whitespace
> > #773: FILE: drivers/dma/sirf-dma.c:649:
> > +^I$
> > 
> > 
> > Also there are bunch of 80char warning, see if you can reduce/eliminate
> > them without sacrificing the code readability, and looking at them it
> > seems possible
> 
> 80char warnings about printks should be ignored, because breaking kernel
> messages across lines prevents them from being greppable.  This (breaking
> kernel messages, particularly error messages, across multiple lines) is a
> topic Linus has frequently complained about.
Sure, I wasn't complaining about printks, btw none of them were hit by
printks.

These were mostly write_l exceeding 80chars, thats why my suggestion to
see if they can be reduced/eliminated without sacrificing code
readability


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/