Re: [PATCH 2/2] ASoC: tlv320aic3x: Clear BIT_CLK_MASTER andWORD_CLK_MASTER bits for for slave mode

[Girdwood, Liam]

On 27 October 2011 09:38, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> According to the datasheet:
>
> Page0 / Register8: Audio Serial Data interface Control Register A
> BIT 7: Bit Clock Directional Control
> Â Â Â Â0: Bit clock is an input (slave mode)
> Â Â Â Â1: Bit clock is an output (master mode)
>
> BIT 6: Word Clock Directional Control
> Â Â Â Â0: Word clock is an input (slave mode)
> Â Â Â Â1: Word clock is an output (master mode)
>
> Current code sets BIT_CLK_MASTER and WORD_CLK_MASTER bits for master mode,
> but does not clear these bits for slave mode.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Âsound/soc/codecs/tlv320aic3x.c | Â Â1 +
> Â1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index a77f6ea..14cb553 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1021,6 +1021,7 @@ static int aic3x_set_dai_fmt(struct snd_soc_dai *codec_dai,
> Â Â Â Â Â Â Â Âbreak;
> Â Â Â Âcase SND_SOC_DAIFMT_CBS_CFS:
> Â Â Â Â Â Â Â Âaic3x->master = 0;
> + Â Â Â Â Â Â Â iface_areg &= ~(BIT_CLK_MASTER | WORD_CLK_MASTER);
> Â Â Â Â Â Â Â Âbreak;
> Â Â Â Âdefault:
> Â Â Â Â Â Â Â Âreturn -EINVAL;
> --
> 1.7.5.4
>
>
>
>

Both

Acked-by: Liam Girdwood <lrg@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/