Re: [PATCH 2/3] Add multi-node boot support

[Ingo Molnar]

* Steffen Persvold <sp@xxxxxxxxxxxxx> wrote:

> > If it's absolutely needed then add a proper quirk handler instead 
> > of polluting the generic code.
> 
> We wanted to reuse as much of the generic AMD code as possible, but 
> it's tricky because most of that code is based around a single HT 
> fabric design, whereas a NumaChip based systems consists of several 
> HT fabrics connected together thus you will have identical 
> NorthBridge IDs (0-7) etc. shared between all systems.
> 
> How would you suggest we add a quirk handler for it ?

So what we want on NumaChip systems is for the node ID in the BIOS 
SRAT table to override the node ID that is read from the hardware, 
right?

Instead of making it a is_numachip_system() thing it would be better 
to detect that the two do not match, and override it if the platform 
says that we should override it - and warn about the mismatch 
otherwise.

Whether to override could be a new srat_override() function in the 
x86_init structure or so.

Thomas, Peter, what do you think?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/