Re: [PATCHSET block:for-3.2/core] rescue cfq from RCU death sprial :)
From: Vivek Goyal
Date: Thu Oct 27 2011 - 11:32:45 EST
On Wed, Oct 26, 2011 at 02:36:29PM -0700, Tejun Heo wrote:
> Hello, again.
> On Tue, Oct 25, 2011 at 06:48:26PM -0700, Tejun Heo wrote:
> > This patchset contains the following 13 patches.
> > 0001-ida-make-ida_simple_get-put-IRQ-safe.patch
> > 0002-block-cfq-move-cfqd-cic_index-to-q-id.patch
> > 0003-block-misc-ioc-cleanups.patch
> > 0004-block-make-ioc-get-put-interface-more-conventional-a.patch
> > 0005-block-misc-updates-to-blk_get_queue.patch
> > 0006-block-cfq-misc-updates-to-cfq_io_context.patch
> > 0007-block-cfq-move-ioc-ioprio-cgroup-changed-handling-to.patch
> > 0008-block-cfq-fix-race-condition-in-cic-creation-path-an.patch
> > 0009-block-cfq-fix-cic-lookup-locking.patch
> > 0010-block-cfq-unlink-cfq_io_context-s-immediately.patch
> > 0011-block-cfq-remove-delayed-unlink.patch
> > 0012-block-cfq-kill-ioc_gone.patch
> > 0013-block-cfq-kill-cic-key.patch
> 0001 removed (realized it's not necessary anymore) and sent out
> separately. 0004 and 0010 updated to address issues Vivek pointed
> out. Both don't affect other patches.
> git branch is updated to reflect the changes including dropping of ide
> related changes from the previous patchset. You won't be able to pull
> this directly as I couldn't use commits for the previous patchset from
> the block tree (they're not there yet).
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-cfq-sync
> When you want the whole series reposted, let me know.
These changes look good to me. It simplifies the locking (yes despite
double lock dance :-)) and gets rid of some race conditions.
Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/