Re: [PATCH 02/10] dmaengine: move drivers to dma_transfer_direction

[Vinod Koul]

On Mon, 2011-10-17 at 14:52 +0200, Guennadi Liakhovetski wrote:

Sorry for replying late...
> > diff --git a/drivers/dma/shdma.c b/drivers/dma/shdma.c
> > index 81809c2..cab7d3e 100644
> > --- a/drivers/dma/shdma.c
> > +++ b/drivers/dma/shdma.c
> > @@ -23,7 +23,6 @@
> >  #include <linux/interrupt.h>
> >  #include <linux/dmaengine.h>
> >  #include <linux/delay.h>
> > -#include <linux/dma-mapping.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_runtime.h>
> >  #include <linux/sh_dma.h>
> > @@ -479,19 +478,19 @@ static void sh_dmae_free_chan_resources(struct
> dma_chan *chan)
> >   * @sh_chan: DMA channel
> >   * @flags:   DMA transfer flags
> >   * @dest:    destination DMA address, incremented when direction
> equals
> > - *           DMA_FROM_DEVICE or DMA_BIDIRECTIONAL
> > + *           DEV_TO_MEM
> >   * @src:     source DMA address, incremented when direction equals
> > - *           DMA_TO_DEVICE or DMA_BIDIRECTIONAL
> > + *           MEM_TO_DEV
> 
> Why have you changed the above two comments? Doesn't seem correct to
> me. 
No this is the right comment.

After the direction flag changes, the sh_dmae_add_desc will take new
flags for direction. The valid flags would be DEV_TO_MEM and
DEV_TO_DEVICE only.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/