Re: [PATCH 1/2] pinmux: Remove double pin validity check.

[Belisko Marek]

On Thu, Oct 27, 2011 at 6:37 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote:
> Belisko Marek wrote at Wednesday, October 26, 2011 2:57 PM:
>> Function pin_is_valid just call pin_desc_get which is in pin_request
>> call some line below. Remove pin_is_valid() check.
> ...
>> @@ -112,16 +112,6 @@ static int pin_request(struct pinctrl_dev *pctldev,
>>
>> Â Â Â dev_dbg(&pctldev->dev, "request pin %d for %s\n", pin, function);
>>
>> - Â Â if (!pin_is_valid(pctldev, pin)) {
>> - Â Â Â Â Â Â dev_err(&pctldev->dev, "pin is invalid\n");
>> - Â Â Â Â Â Â return -EINVAL;
>> - Â Â }
>
> So that makes sense.
>
>> -
>> - Â Â if (!function) {
>> - Â Â Â Â Â Â dev_err(&pctldev->dev, "no function name given\n");
>> - Â Â Â Â Â Â return -EINVAL;
>> - Â Â }
>
> But I don't think you want to remove that? Oh actually, perhaps removing
> that /is/ valid, since it's an internal function and can't be called with
> a NULL function parameter. But, you should mention why in the changelog
> so it doesn't look like a mistake.
Well it's not removed. It's moved below pin_desc_get call.
>
> --
> nvpublic
>
>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/