Re: [PATCH 4/6] arm/tegra: implement support for tegra30

From: Russell King - ARM Linux
Date: Thu Oct 27 2011 - 16:25:17 EST


On Thu, Oct 27, 2011 at 01:10:10PM -0700, Stephen Warren wrote:
> Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM:
> > From: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
>
> Some description here would be nice.

Definitely - it's something which Andrew Morton commented on during
the kernel summit. Commit messages really should sell the patch
they're attached to, so that people reading the kernel commit log
(a) have some idea what the patch is doing and (b) why it's being
added.

So maybe something like:

Add support for the Tegra T30 SoC, found in x, y and z. This
includes a device tree compatible type for this SoC ("nvidia,tegra30")
and adapts the kernels L2 cache initialization for this new SoC.

(That's my best guess based on the contents of this patch.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/