Re: [PATCH] UART: add CSR SiRFprimaII SoC on-chip uart drivers

[Barry Song]

2011/10/28 Baruch Siach <baruch@xxxxxxxxxx>:
> Hi Barry,
>
> On Thu, Oct 27, 2011 at 08:27:33PM -0700, Barry Song wrote:
>> From: Rong Wang <Rong.Wang@xxxxxxx>
>>
>> SiRFprimaII is the latest generation application processor from CSRâs
>> multi-function SoC product family.
>> The SoC support codes are in arch/arm/mach-prima2 from Linux mainline
>> 3.0.
>>
>> There are three dedicated UARTs in system. This patch adds basic driver
>> support for them.
>>
>> It has used the newest pinmux subsystem from Linus Walleij.
>>
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Signed-off-by: Rong Wang <Rong.Wang@xxxxxxx>
>> Signed-off-by: Bin Shi <Bin.Shi@xxxxxxx>
>> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx>
>> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
>> ---
>
> [snip]
>
>> +config SERIAL_SIRFSOC
>> + Â Â Â Âtristate "SiRF SoC Platform Serial port support"
>> + Â Â Â Âdepends on ARM && ARCH_PRIMA2
>> + Â Â Â Âselect SERIAL_CORE
>> + Â Â Â Âhelp
>> + Â Â Â Â ÂSupport for the on-chip UART on the CSR SiRFprimaII series,
>> + Â Â Â Â Âproviding /dev/ttyS0, 1 and 2 (note, some machines may not
>> + Â Â Â Â Âprovide all of these ports, depending on how the serial port
>> + Â Â Â Â Âpins are configured.
>
> Unbalanced parentheses.

Hi Baruch,
Thanks for reviewing! I sent this mail for Torvalds to pick seperately
since it depends on pinctl tree, and it was not gone through tty tree
since tty has no pinctrl before linus merges it.
This patch has been reviewed and acked in linux-serial, unfortunately,
missed this error.
i am not sure whether i will make Linus confused if i send a new
version at this moment. how about i send a seperate patch to fix this
after the driver is applied?

>
> baruch
>
> --
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ~. .~ Â Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> Â - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/