Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRCbug.

[Alan Cox]

On Thu, 27 Oct 2011 13:55:21 -0500
Paul Schilling <paul.s.schilling@xxxxxxxxx> wrote:

> The Vortex86dx uses RDC IDE peripheral integrated into the SOC.  The
> CRC design is
> broken in the Vortex86dx and sx.  The original reference can be found
> in the Linux kernel itself.
> 
> The Vortex86sx uses the RDC D1010.
> The Vortex86dx uses the RDC D1011.
> Both of which have broken CRC hardware which breaks DMA.

CRC hardware is only used for *UDMA* yet your change also disabled MWDMA.


> >> Â Â Â static const struct ata_port_info info_rdc_11 = {
> >> Â Â Â Â Â Â Â .flags = ATA_FLAG_SLAVE_POSS,
> >> Â Â Â Â Â Â Â .pio_mask = ATA_PIO4,
> >> - Â Â Â Â Â Â .mwdma_mask = ATA_MWDMA2,
> >> + Â Â Â Â Â Â .mwdma_mask = 0,
> >> + Â Â Â Â Â Â .udma_mask = 0,

Why ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/