Re: [PATCH] of: include errno.h

[Grant Likely]

On Sat, Oct 29, 2011 at 10:38:16AM +0200, Geert Uytterhoeven wrote:
> On Thu, Oct 6, 2011 at 14:40, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
> > When compiling ath6kl for beagleboard (omap2plus_defconfig plus
> > CONFIG_ATH6KL, CONFIG_OF disable) with current linux-next compilation
> > fails:
> >
> > include/linux/of.h:269: error: 'ENOSYS' undeclared (first use in this function)
> > include/linux/of.h:276: error: 'ENOSYS' undeclared (first use in this function)
> > include/linux/of.h:289: error: 'ENOSYS' undeclared (first use in this function)
> 
> And now this build failure (also on m68k) has hit Linus' tree, more
> than 3 weeks after
> its detection in -next...
> 
> > Fix this by including errno.h from of.h.
> >
> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
> 
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Appied, thanks, and I'll push out to Linus as soon as the test build finishes.

g.

> 
> > ---
> >  include/linux/of.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9180dc5..219c29d 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -17,6 +17,7 @@
> >  */
> >  #include <linux/types.h>
> >  #include <linux/bitops.h>
> > +#include <linux/errno.h>
> >  #include <linux/kref.h>
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/spinlock.h>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/