Re: [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver

[Taehun Kim]

2011/10/25 David Miller <davem@xxxxxxxxxxxxx>:
> From: Taehun Kim <kth3321@xxxxxxxxx>
> Date: Sat, 22 Oct 2011 17:41:56 +0900
>
>> +struct wiz_private {
>> + Â Â void __iomem *base;
>> + Â Â struct net_device *dev;
>> + Â Â u8 rxbuf_conf[MAX_SOCK_NUM];
>> + Â Â u8 txbuf_conf[MAX_SOCK_NUM];
>> + Â Â struct net_device_stats stats;
>> + Â Â struct napi_struct napi;
>> + Â Â spinlock_t lock;
>> + Â Â u32 msg_enable;
>> +};
>
> You don't need to have a private net_device_stats, just use the
> one in struct net_device, and then you can also get rid of your
> private ->ndo_get_stats() method.
>

Thank you for your feedback :)

I am working on this drive by referencing other Ethernet drivers.
I have one question.

Should I suggest the updated driver patch to this thread or new
thread?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/