Re: [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file

From: Mark Brown
Date: Wed Nov 16 2011 - 09:37:34 EST


On Wed, Nov 16, 2011 at 03:30:13PM +0100, Patrick Combes wrote:

> > ...this doesn't do anything to stop userspace doing multiple enables and
> > disables.

> Do you mean there is a need to prevent that?
> Basically the code above accepts both "1" or "enable" strings to enable the
> property. I could limit that to "enable" / "disable" if it is confusing.

That's not the problem. The problem is that if you disable it might not
actually disable the wake if it's previously been enabled multiple times.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/