Re: [PATCH 2/8] serial: 8250: Add ioctl to enable auto rs485 modewith some Exar UARTs

[Wolfram Sang]

> > +		if (serial_inp(up, UART_FCTR)&  UART_FCTR_RS485)
> > +			rs485ctrl.flags = SER_RS485_ENABLED;
> > +		else
> > +			rs485ctrl.flags = 0;
> 
> This else branch may be removed, since the structure has been already memsetted to 0.

Correct, yet I didn't want to change Matthias' code, so reviewers can
skip this patch if they reviewed his old code already. Flag handling
will be handled different with the next patch anyway.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature