Re: [Xen-devel] Re: [PATCH 1/3] xen/granttable: Introducing granttable V2 stucture

[ANNIE LI]

On 2011-11-18 0:29, Konrad Rzeszutek Wilk wrote:
> > > The more normal way to do this would be to make gnttab_interface a
> > > pointer, define gnttab_v1_ops and do:
> > > 	gnttab_interface =&gnttab_v1_ops;
> > > or if the pointer overhead is significant remove that and just do a
> > > struct assignment:
> > > 	gnttab_interface = gnttab_v1_ops;
> > If using this way, we need two more public structures(gnttab_v1_ops
> > and gnttab_v2_ops), and two more functions to initialize those two
> > structures and then initialize the pointer gnttab_interface. It is
> > more complicated, am i missing something?
> Why two functions? I agree on the structures - but they need not to be
> public (they can be static).
>
> For a good example look at how apic_physflat is done.
Thanks, static structure is simpler and clean. I am very glad to change 
that.:-)

Thanks
Annie
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/