Re: [PATCH] pipe: Fail cleanly when root tries F_SETPIPE_SZ with bigsize

From: Al Viro
Date: Fri Nov 18 2011 - 15:25:54 EST


On Fri, Nov 18, 2011 at 10:04:34PM +0200, Sasha Levin wrote:

> + if (nr_pages * sizeof(struct pipe_buffer) > KMALLOC_MAX_SIZE)
> + return -ENOMEM;

nr_pages is unsigned long, sizeof is greater than 1, KMALLOC_MAX_SIZE is
unsigned long... So write that check as KMALLOC_MAX_SIZE / sizeof > nr_pages
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/