Re: [PATCH v3.1] [resend] Resurrect Intel740 driver: i740fb

[Ondrej Zary]

On Saturday 19 November 2011 00:53:27 Tabi Timur-B04825 wrote:
> On Fri, Nov 18, 2011 at 2:54 PM, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> 
wrote:
> > Hello,
> > this is an v3 attempt to resurrect an old (like 2.4.19) out-of-tree
> > driver for Intel740 graphics cards and modify it for recent kernels. The
> > old driver is located at:
> > http://sourceforge.net/projects/i740fbdev/files/
>
> Would you please run checkpatch.pl on the patch and fix the complaints
> it has?  I get this:
>
> total: 45 errors, 67 warnings, 1619 lines checked
>
> This patch has tons of style problems.

The 45 errors are in i740_calc_fifo(), which now looks good and is readable. 
Reformatting according to checkpatch makes it look bad and unredable. This 
was already discussed before.
The warnings are lines over 80 characters, which are common in most fb 
drivers. Splitting them makes code hard to read.

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/