Re: [PATCH 1/1] __send_signal: pass q->info, not info, touserns_fixup_signal_uid (v2)

[Andrew Morton]

On Sat, 19 Nov 2011 17:06:49 +0100
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> On 11/19/2011 01:41 AM, Serge Hallyn wrote:
> > Eric Biederman pointed out that passing info is a bug and could lead
> > to a NULL pointer deref to boot.
> 
> It would be great if you could describe what bug you are fixing in fact
> in the commit log. "Something that could lead to a bug" is not helpful
> at all.
> 
> A link to the thread where Eric pointed *that* out would be enough.

What Serge is secretly hiding from everyone is that this patch is a
fixup against his earlier "user namespace: make signal.c respect user
namespaces v5".  So the fix isn't very interesting for people who
aren't running that patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/