Re: [PATCH] MIPS: Add RTC support for loongson1B

[Linus Walleij]

On Mon, Nov 21, 2011 at 9:37 AM,  <zhzhl555@xxxxxxxxx> wrote:

> From: zhao zhang <zhzhl555@xxxxxxxxx>
>
> This patch add RTC support(TOY counter0) for loongson1B
> Signed-off-by: zhao zhang <zhzhl555@xxxxxxxxx>
(...)
> +       __raw_writel(v, SYS_TOYWRITE0);

Why are you using __raw_* accessors everywhere?
Is something wrong with just writel()/readl() on loongson?

When I look in arch/mips/include/asm/io.h they actually
seem to be #defined to their __raw_* counterparts anyway
so it cannot hurt.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/