Re: [PATCH] pinctrl: GPIO direction support for muxing

[Thomas Abraham]

On 21 November 2011 18:29, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> wrote:
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> When requesting a single GPIO pin to be muxed in, some controllers
> will need to poke a different value into the control register
> depending on whether the pin will be used for GPIO output or GPIO
> input. So create pinmux counterparts to gpio_direction_[input|output]
> in the pinctrl framework.

Reviewed-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx>

One minor comment below.

>

[...]

> diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt
> index 214b961..4a946ba 100644
> --- a/Documentation/pinctrl.txt
> +++ b/Documentation/pinctrl.txt

[...]

> +Alternatively to using these special functions, it is fully allowed to use
> +named functions for each GPIO pin, the pinmux_request_gpio() will attempt to
> +obtain the function "gpioN" where "N" is the global GPIO pin number if no
> +special GPIO-handler is registered.
> +
> +The public functions to enable a certain GPIO pin

Is the above sentence incomplete?

Thanks,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/