RE: [PATCH v2 5/5] perf: Enable applicable siblings when groupleader is enable-on-exec

[Peter Zijlstra]

On Tue, 2011-11-22 at 14:20 +0000, Zhu, DengCheng wrote:
> > @@ -2463,11 +2461,25 @@ static int event_enable_on_exec(struct p
> >        if (event->state >= PERF_EVENT_STATE_INACTIVE)
> >                return 0;
> >
> > -       __perf_event_mark_enabled(event, ctx);
> > +       event->state = PERF_EVENT_STATE_INACTIVE;
> >
> >        return 1;
> >  }
> 
> By simply setting the event state in here, we bypass time stamp stuff as a result.
> This might lead to inaccuracies... 

Ah, but it calls a __perf_event_mark_enabled() at the tail of
group_enable_on_exec() which should fix that up, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/