Re: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor

From: Alan Stern
Date: Tue Nov 22 2011 - 11:26:07 EST


On Tue, 22 Nov 2011, Aman Deep wrote:

> xhci-hub used some numerical values for initialisation of root hub
> descriptors. #define values are addded in usb 2.0 hub specification
> file and these values are used for root hub characteristics
> initialisation.
>
> Also use some #defines in places where magic numbers are being used.

This is good. Can you also add similar changes to hub_configure() in
drivers/usb/core/hub.c?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/