Re: [PATCH] drm/i915: By default, enable RC6 on IVB and SNB whenreasonable

From: Matthew Garrett
Date: Tue Nov 22 2011 - 15:15:39 EST


On Fri, Nov 18, 2011 at 10:41:29PM -0800, Keith Packard wrote:

> + /*
> + * Only enable RC6 if all dma remapping is disabled, or if
> + * there's no iommu present in the machine.
> + */
> + if (INTEL_INFO(dev)->gen == 6)
> + return no_iommu || dmar_disabled;

So the user has to choose between 5W of power saving or having dmar? And
we default to giving them dmar? I think that's going to come as a
surprise to people.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/